-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor shared config Loading #990
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skotambkar
force-pushed
the
config-parity
branch
from
December 21, 2020 08:23
4b432be
to
6cf685c
Compare
skotambkar
changed the title
Draft PR for Shared Config Loading
refactor shared config Loading
Dec 21, 2020
jasdel
reviewed
Dec 21, 2020
skotambkar
force-pushed
the
config-parity
branch
from
December 22, 2020 05:36
6cf685c
to
7937434
Compare
jasdel
reviewed
Dec 22, 2020
jasdel
approved these changes
Dec 22, 2020
skotambkar
force-pushed
the
config-parity
branch
from
December 22, 2020 21:47
a854374
to
8ba8642
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for Shared Config Loading
Changes:
TODO:
[ x ] More TESTING
[ x ] Error handling.
[ x ] Logs things that are dropped.
[ x ] Documentation update
[ x ] Config SourceFile should be a list of all filenames that were used to get Config